Skip to content

Conversation

@LauraCForgeFlow
Copy link

No description provided.

@LauraCForgeFlow LauraCForgeFlow force-pushed the 16.0-mig-account_payment_mode_default_account branch from c6bf5b9 to f62067f Compare September 23, 2024 06:35
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
@github-actions github-actions bot closed this Mar 2, 2025
Comment on lines 17 to 35
property_stored_account_receivable_id = fields.Many2one(
"account.account",
company_dependent=True,
string="Account Receivable",
domain="[('internal_type', '=', 'receivable'), ('deprecated', '=', False), ('company_id', '=', current_company_id)]", # noqa
)

property_account_payable_id = fields.Many2one(
company_dependent=False,
compute="_compute_property_account_payable_id",
inverse="_inverse_property_account_payable_id",
)

property_stored_account_payable_id = fields.Many2one(
"account.account",
company_dependent=True,
string="Account Payable",
domain="[('internal_type', '=', 'payable'), ('deprecated', '=', False), ('company_id', '=', current_company_id)]", # noqa
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LauraCForgeFlow I have this warning:

Two fields (property_stored_account_receivable_id, property_account_receivable_id) of res.users() have the same label: Account Receivable
Two fields (property_stored_account_payable_id, property_account_payable_id) of res.users() have the same label: Account Payable.

Maybe we could change the string to something different? Like Account Receivable Stored and Account Payable Stored?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I changed the string to avoid this problem. Thanks! :)

Copy link

@RicardCForgeFlow RicardCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that warning, functional and code review are okay!

@LauraCForgeFlow LauraCForgeFlow force-pushed the 16.0-mig-account_payment_mode_default_account branch from f62067f to faec591 Compare June 27, 2025 06:14
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 29, 2025
@JordiMForgeFlow
Copy link
Contributor

@JordiBForgeFlow could we get this one merged?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants